[feat](job)Internal job cancellation immediately and the strong association with the STARTS parameter #36805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
…iation with the STARTS parameter For internal tasks, such as MTMV, the start time may already be set, or the time may be adjusted immediately.
CalvinKirs
force-pushed
the
master-job-set-starttime
branch
from
082863c
to
d298cb4
Compare
|
run buildall |
TPC-H: Total hot run time: 40447 ms |
TPC-DS: Total hot run time: 174849 ms |
ClickBench: Total hot run time: 30.7 s |
zddr
reviewed
Jun 26, 2024
| @@ -149,6 +150,8 @@ public void analyze(Analyzer analyzer) throws UserException { | |||
| if (null != startsTimeStamp) { | |||
| if (startsTimeStamp.equalsIgnoreCase(CURRENT_TIMESTAMP_STRING)) { | |||
| jobExecutionConfiguration.setImmediate(true); | |||
| //To avoid immediate re-scheduling, set the start time of the timer 100ms before the current time. | |||
| timerDefinition.setStartTimeMs(System.currentTimeMillis() - 100L); | |||
There was a problem hiding this comment.
what will happen if not set startTimemMs?
There was a problem hiding this comment.
The syntax for Create Job doesn't immediately schedule the job. For a one-time schedule, setting the start time to CURRENT_TIMESTAMP achieves immediate scheduling. Therefore, we still need to set the startTime parameter; otherwise, the job query will lack a start time.
| @@ -124,6 +124,10 @@ public void scheduleOneJob(T job) throws JobException { | |||
| schedulerInstantJob(job, TaskType.SCHEDULED, null); | |||
| } | |||
| } | |||
| if (job.getJobConfig().isImmediate() && JobExecuteType.ONE_TIME.equals(job.getJobConfig().getExecuteType())) { | |||
There was a problem hiding this comment.
why JobExecuteType == ONE_TIME ,can not setLatestSchedulerTimeMs(System.currentTimeMillis())?
There was a problem hiding this comment.
This variable is not persistent, so for a one-time, immediately scheduled task, there's no need to set it.
zddr
approved these changes
Jun 27, 2024
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 40034 ms |
TPC-DS: Total hot run time: 173127 ms |
ClickBench: Total hot run time: 30.48 s |
|
run buildall |
TPC-H: Total hot run time: 39467 ms |
TPC-DS: Total hot run time: 173614 ms |
ClickBench: Total hot run time: 30.55 s |
|
run buildall |
TPC-H: Total hot run time: 39815 ms |
TPC-DS: Total hot run time: 173584 ms |
ClickBench: Total hot run time: 31.26 s |
|
run external |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
…iation with the STARTS parameter (#36805) ## Proposed changes For internal tasks, such as MTMV, the start time may already be set, or the time may be adjusted immediately. <!--Describe your changes.-->
CalvinKirs
added a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Jul 19, 2024
…iation with the STARTS parameter (apache#36805) ## Proposed changes For internal tasks, such as MTMV, the start time may already be set, or the time may be adjusted immediately. <!--Describe your changes.--> (cherry picked from commit 904a6c0)
yiguolei
pushed a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Jul 31, 2024
…iation with the STARTS parameter (apache#36805) ## Proposed changes For internal tasks, such as MTMV, the start time may already be set, or the time may be adjusted immediately. <!--Describe your changes.--> (cherry picked from commit 904a6c0)
morrySnow
pushed a commit
that referenced
this pull request
Aug 29, 2024
extends: #36805 Previously, if the user set immediate execution, the current time would replace the user's set start time
zddr
added a commit
to zddr/incubator-doris
that referenced
this pull request
Sep 5, 2024
extends: apache#36805 Previously, if the user set immediate execution, the current time would replace the user's set start time
CalvinKirs
added a commit
that referenced
this pull request
Sep 5, 2024
…iation with the STARTS parameter (#36805) (#38110) … ## Proposed changes For internal tasks, such as MTMV, the start time may already be set, or the time may be adjusted immediately. <!--Describe your changes.--> (cherry picked from commit 904a6c0) ## Proposed changes Issue Number: close #36805 <!--Describe your changes.-->
dataroaring
pushed a commit
that referenced
this pull request
Sep 26, 2024
extends: #36805 Previously, if the user set immediate execution, the current time would replace the user's set start time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
For internal tasks, such as MTMV, the start time may already be set, or the time may be adjusted immediately.